-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds new landing page and updates internal page styling #2055
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
feat: docs - more css updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the comments are on that tracking sheet, but adding some comments here that are more code specific as well!
.vscode/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need all this. Maybe just ignore .idea/
?
.idea/.gitignore
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove all these .idea files form the PR (just don't commit them).
theme/css/colors.css
Outdated
/* Text Colors */ | ||
--text-black: #292321; | ||
--text-red: #A30000; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lots of missing newlines at end of files.
theme/icons/.DS_Store
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove all .DS_Store
files
theme/js/index.js
Outdated
mobileNavSearchForm.style.display = 'none'; | ||
}); | ||
|
||
// Parallax functionality |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this whole code block would be less jerky if you dynamically updated the element css to switch between position fixed and relative--so the render engine will keep fixed rather than trying to dynamically set a height in js. Not a web dev expert though!
theme/landing.html
Outdated
</button> | ||
<pre> | ||
<code class="language-python"> | ||
inputs = keras.Input(shape=(32, 32, 3)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove the tab from these pre blocks so they copy without extra spaces. Instead just style the code card padding to get whatever left alignment we want.
fix: docs styling - addressing QA feedback
fix: landing page - sticky textbox section fix
This pull request revises the landing page code to align with new designs.
This pull request also updates the internal pages to ensure consistent navigation and styling with the landing page.