Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new landing page and updates internal page styling #2055

Open
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

alexabbott
Copy link

This pull request revises the landing page code to align with new designs.

This pull request also updates the internal pages to ensure consistent navigation and styling with the landing page.

Copy link

google-cla bot commented Mar 4, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the comments are on that tracking sheet, but adding some comments here that are more code specific as well!

.vscode/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need all this. Maybe just ignore .idea/?

.idea/.gitignore Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all these .idea files form the PR (just don't commit them).

/* Text Colors */
--text-black: #292321;
--text-red: #A30000;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of missing newlines at end of files.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove all .DS_Store files

mobileNavSearchForm.style.display = 'none';
});

// Parallax functionality
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this whole code block would be less jerky if you dynamically updated the element css to switch between position fixed and relative--so the render engine will keep fixed rather than trying to dynamically set a height in js. Not a web dev expert though!

</button>
<pre>
<code class="language-python">
inputs = keras.Input(shape=(32, 32, 3))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the tab from these pre blocks so they copy without extra spaces. Instead just style the code card padding to get whatever left alignment we want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants