Skip to content

Conversation

@shashaka
Copy link
Contributor

I added the following functions to api_master.py:

keras.ops.gcd
keras.ops.isneginf
keras.ops.isposinf
keras.ops.isreal
keras.ops.kron
keras.ops.lcm
keras.ops.hypot
keras.ops.trapezoid
keras.ops.view

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @shashaka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates several new operational functions into the keras.ops module, expanding the library's mathematical and utility capabilities. The primary goal is to align with and support the features introduced in Keras 3.12.0, ensuring that users have access to a broader set of low-level operations for tensor manipulation and computation.

Highlights

  • New Keras Ops APIs: Introduced nine new operational APIs to the keras.ops module, including gcd, isneginf, isposinf, isreal, kron, lcm, hypot, trapezoid, and view.
  • Keras 3.12.0 Support: These additions are specifically implemented to ensure compatibility and support for Keras version 3.12.0.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds several new operations to the Keras ops API, specifically within the NumPy ops section. The new ops are added in the correct alphabetical order, and the changes are straightforward. I also noticed and appreciate the minor formatting fix to align the indentation of the muon optimizer entry with the rest of the file. My main feedback is a suggestion to improve the long-term maintainability of api_master.py by refactoring the growing list of NumPy ops, which I've detailed in a specific comment.

Copy link
Collaborator

@sachinprasadhs sachinprasadhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

@sachinprasadhs sachinprasadhs merged commit c15b2c7 into keras-team:master Oct 30, 2025
4 checks passed
@shashaka shashaka deleted the ops branch October 30, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants