-
Notifications
You must be signed in to change notification settings - Fork 19.6k
Resolve: [Good First Issue][Keras 3 OpenVINO Backend]: Support numpy.linspace operation #29485 #21140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@rkazants may you review this? |
I have collected some errors, gonna fix it:
E AttributeError: 'OpenVINOKerasTensor' object has no attribute 'numpy'
E AttributeError: 'numpy.ndarray' object has no attribute 'numpy'. Did you mean: 'dump'?
E AttributeError: 'jaxlib.xla_extension.ArrayImpl' object has no attribute 'numpy'
E TypeError: num must be an integer
|
keras/src/ops/numpy.py
Outdated
@@ -3468,51 +3468,100 @@ def compute_output_spec(self, start, stop): | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
incorrect file is modified. You need to update https://github.com/keras-team/keras/blob/master/keras/src/backend/openvino/numpy.py
pytest.ini
Outdated
@@ -0,0 +1,3 @@ | |||
[pytest] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove this file. It is needed only for developer purpose
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21140 +/- ##
==========================================
- Coverage 82.59% 79.83% -2.76%
==========================================
Files 564 564
Lines 54367 54440 +73
Branches 8452 8466 +14
==========================================
- Hits 44902 43460 -1442
- Misses 7391 8966 +1575
+ Partials 2074 2014 -60
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
\q ranch 'linspace_func' of https://github.com/VLTisME/keras_forked into linspace_func
@VLTisME, please fix test failures, see CI logs:
|
i am working on it, thanks for your review |
Why do all the tests pass when I run them locally (except for a few skipped ones), but when I push the code here, so many tests fail?
|
Reduced failed tests to 2 failed and 12 skipped.
two left unsolved failed tests:
1/
start = 0, stop = 10, num = <tf.Tensor: shape=(), dtype=int32, numpy=5>
endpoint = True, retstep = False, dtype = None, axis = 0
E TypeError: num must be an integer
2/
E TypeError: 'NoneType' object cannot be interpreted as an integer