Skip to content

This PR implements the numpy.logspace function for the OpenVINO backend as requested in issue #30114. #21266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

sanleo-wq
Copy link
Contributor

  • Follows the same pattern as other similar functions in the file
  • Passes all tests (63 test cases)

I've removed the test from the excluded tests list, which allows for proper validation of the functionality.

@rkazants for review
All tests are passing:

Copy link

google-cla bot commented May 8, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov-commenter
Copy link

codecov-commenter commented May 8, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.57%. Comparing base (24d226b) to head (969b6d1).

Files with missing lines Patch % Lines
keras/src/backend/openvino/numpy.py 91.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21266   +/-   ##
=======================================
  Coverage   82.57%   82.57%           
=======================================
  Files         564      564           
  Lines       54656    54680   +24     
  Branches     8496     8500    +4     
=======================================
+ Hits        45131    45152   +21     
- Misses       7435     7438    +3     
  Partials     2090     2090           
Flag Coverage Δ
keras 82.38% <91.66%> (+<0.01%) ⬆️
keras-jax 63.60% <0.00%> (-0.03%) ⬇️
keras-numpy 58.73% <0.00%> (-0.03%) ⬇️
keras-openvino 33.04% <91.66%> (+0.03%) ⬆️
keras-tensorflow 64.01% <0.00%> (-0.03%) ⬇️
keras-torch 63.67% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gbaned gbaned added this to PR Queue May 12, 2025
@github-project-automation github-project-automation bot moved this to Assigned Reviewer in PR Queue May 12, 2025
@gbaned gbaned requested a review from mattdangerw May 12, 2025 09:54
.ruff_cache
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove it

Copy link
Contributor

@rkazants rkazants May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not addressed comment

@@ -0,0 +1,3 @@
[pytest]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not addressed comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Assigned Reviewer
Development

Successfully merging this pull request may close these issues.

4 participants