Implement numpy.prod method for OpenVino backend #21282
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21282 +/- ##
==========================================
- Coverage 82.57% 82.55% -0.03%
==========================================
Files 564 564
Lines 54677 54695 +18
Branches 8500 8505 +5
==========================================
Hits 45152 45152
- Misses 7435 7453 +18
Partials 2090 2090
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rkazants
reviewed
May 15, 2025
Comment on lines
+1254
to
+1255
| if dtype is None and original_type != result.get_element_type(): | ||
| result = ov_opset.convert(result, original_type).output(0) |
There was a problem hiding this comment.
according to the logic, if dtype is None, original_type is always equal to result's one. Please correct me.
That is because reshape and reduce_prod preserve tensor type:)
rkazants
reviewed
May 15, 2025
| .ruff_cachekeras_venv/ |
There was a problem hiding this comment.
please remove changes here.
Switch on tests for prod.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #30212
Follows the same pattern as other similar functions in the file
Passes all tests
I've removed the test from the excluded tests list, which allows for proper validation of the functionality.
@rkazants for review
All tests are passing