Skip to content

use native dumpy conversion when available #21288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

supersimple33
Copy link

I was getting the following error when I was trying to save a model I made using a PennyLane qnn layer.
DeprecationWarning: __array__ implementation doesn't accept a copy keyword, so passing copy=False failed. __array__ must implement 'dtype' and 'copy' keyword arguments. I just made this small change which uses and objects native bumpy conversion if it exists.

Copy link

google-cla bot commented May 15, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.82%. Comparing base (dfaca0e) to head (d5f0d35).

❗ There is a different number of reports uploaded between BASE (dfaca0e) and HEAD (d5f0d35). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (dfaca0e) HEAD (d5f0d35)
keras 5 4
keras-tensorflow 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21288      +/-   ##
==========================================
- Coverage   82.57%   76.82%   -5.76%     
==========================================
  Files         564      564              
  Lines       54677    54677              
  Branches     8500     8500              
==========================================
- Hits        45152    42006    -3146     
- Misses       7435    10528    +3093     
- Partials     2090     2143      +53     
Flag Coverage Δ
keras 76.67% <100.00%> (-5.72%) ⬇️
keras-jax 63.61% <100.00%> (ø)
keras-numpy 58.74% <100.00%> (ø)
keras-openvino 33.04% <0.00%> (ø)
keras-tensorflow ?
keras-torch 63.68% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gbaned gbaned added this to PR Queue May 16, 2025
@github-project-automation github-project-automation bot moved this to Assigned Reviewer in PR Queue May 16, 2025
@gbaned gbaned requested a review from fchollet May 16, 2025 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Assigned Reviewer
Development

Successfully merging this pull request may close these issues.

3 participants