x86/bpf: do not audit capability check in do_jit() #10059
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upstream branch: 04a8995 |
|
Upstream branch: 04a8995 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1014021=>bpf-next
branch
from
0f193cb to
4ef034f
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
6efc16b to
55beced
Compare
|
Upstream branch: 96d31df |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1014021=>bpf-next
branch
from
4ef034f to
8b63757
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
55beced to
b92bbe4
Compare
|
Upstream branch: e758657 |
The failure of this check only results in a security mitigation being applied, slightly affecting performance of the compiled BPF program. It doesn't result in a failed syscall, an thus auditing a failed LSM permission check for it is unwanted. For example with SELinux, it causes a denial to be reported for confined processes running as root, which tends to be flagged as a problem to be fixed in the policy. Yet dontauditing or allowing CAP_SYS_ADMIN to the domain may not be desirable, as it would allow/silence also other checks - either going against the principle of least privilege or making debugging potentially harder. Fix it by changing it from capable() to ns_capable_noaudit(), which instructs the LSMs to not audit the resulting denials. Link: https://bugzilla.redhat.com/show_bug.cgi?id=2369326 Fixes: d4e89d2 ("x86/bpf: Call branch history clearing sequence on exit") Signed-off-by: Ondrej Mosnacek <[email protected]> Reviewed-by: Paul Moore <[email protected]>
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1014021=>bpf-next
branch
from
8b63757 to
e9a6d81
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1014021 irrelevant now. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: x86/bpf: do not audit capability check in do_jit()
version: 2
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1014021