Skip to content

bpf: Reject negative head_room in __bpf_skb_change_head #10079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Parent: bpf: Fix tr dereference
wants to merge 1 commit into
base: bpf_base
Choose a base branch
from
+2 −1
Open

bpf: Reject negative head_room in __bpf_skb_change_head #10079

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion net/core/filter.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3877,7 +3877,8 @@ static inline int __bpf_skb_change_head(struct sk_buff *skb, u32 head_room,
u32 new_len = skb->len + head_room;
int ret;

if (unlikely(flags || (!skb_is_gso(skb) && new_len > max_len) ||
if (unlikely(flags || (int)head_room < 0 ||
(!skb_is_gso(skb) && new_len > max_len) ||
new_len < skb->len))
return -EINVAL;

Expand Down
Loading