Test: ingester file functions unit tests #1592
Open
+787
−348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even with this reduction, it's still hard to lower the complexity even further without creating idempotent functions Closes kernelci#1571
MarceloRobert
force-pushed
the
feat/ingester-unit-one
branch
from
84235e6 to
b3800d9
Compare
MarceloRobert
changed the title
MarceloRobert
requested review from
Copilot and
gustavobtflores
and removed request for
Copilot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #1574, so the first 7 commits are not meant to be reviewed, just the last one.
I can't change the base since the base is from my own fork, so it wouldn't make sense to have a base branch and incoming branch be from the same fork but the PR be in a different repository, Github doesn't allow it.
Changes
load_tree_names,
move_file_to_failed_dir,
verify_dir,
verify_spool_dirs,
How to test
Run the unit tests of the file and check that they are all passing.
Also check if the test cases cover the function well
Part of #1569