Switch Trigger Service main loop data structure #1206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawiecz
force-pushed
the
switch-trigger-loop-structure
branch
from
dd9d9dd to
6d51916
Compare
This reverts commit 81387ab. Build configurations list will not be known up front when external configuration files are enabled in Maestro. Dropping this filter will allow simplifying Trigger Service logic taking into account only parameters that are still relevant. Signed-off-by: Paweł Wieczorek <[email protected]>
Build configurations list will not be known up front when external configuration files are enabled in Maestro. Switching main loop to iterate over monitored trees will allow obtaining this information right before its use. Signed-off-by: Paweł Wieczorek <[email protected]>
pawiecz
force-pushed
the
switch-trigger-loop-structure
branch
from
6d51916 to
f3930de
Compare
pawiecz
removed
the
staging-skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build configurations list will not be known up front when external configuration files are enabled in Maestro. Dropping
build_configsfilter will allow simplifying Trigger Service logic taking into account only parameters that are still relevant.