-
Notifications
You must be signed in to change notification settings - Fork 34
Introduce pipeline cron service #1320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
a8ec0ac
to
7503823
Compare
70d9705
to
3d375d2
Compare
The code inside kernelci-pipeline should be only relevant to "Modular pipeline based on the KernelCI API" |
5b0763c
to
06be9a9
Compare
docker/cron/Dockerfile
Outdated
# | ||
# Copyright (C) 2025 Collabora Limited | ||
# Author: Jeny Sadadia <[email protected]> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We dont use Dockerfiles anymore, images should be built using kci tool in https://github.com/kernelci/kernelci-core/blob/cc5803a237a2bf22c7bfed7c4ccb445808b5084d/.github/workflows/docker_images.yml#L104
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated it.
@@ -0,0 +1,9 @@ | |||
UPLOAD_PATH="kci-dev/report" | |||
FILE_PATH="/home/kernelci/logs/" | |||
STORAGE_URL="https://files-staging.kernelci.org/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will restrict us only to use kernelci-storage and we will have to duplicate secret data that is already available for kernelci-pipeline services in kernelci-secrets.toml (default storage config, then [storage.name] section and storage_cred. Same for email, we was using email data in toml file, so better we keep using this config for such data.
Even if we can leave kernelci-storage only for now, we should use toml file as configuration, otherwise it will significantly complicate deployment procedure and multiply places where secrets kept.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you suggest to skip uploading report on the storage and directly send an email?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about I use the same pipeline .env
that other services are already using?
@@ -0,0 +1,13 @@ | |||
default_instance="production" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this file available within kci-dev tool: https://github.com/kernelci/kci-dev/blob/7007c8c5176cb1a40d25d5569b5c66756f6fffc3/kcidev/_data/kci-dev.toml.example#L5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's an example file. We need to create kci-dev.toml
to make the command work.
docker-compose-cron.yaml
Outdated
|
||
cron: | ||
container_name: 'kernelci-pipeline-cron' | ||
build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be used in production, we should specify image name in registry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. I'll work on that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it.
a6551b8
to
abca922
Compare
Implement a service to run a cron job in pipeline. This cron job will run `kci-dev maestro validate` command to run validation for builds and boots results of maestro against webdashboard. The cron job is scheduled to run every Sunday at 12:00 AM. The report will be uploaded to storage. An email notification will be sent out with report URL and its content. Signed-off-by: Jeny Sadadia <[email protected]>
abca922
to
0fb13e2
Compare
Depends on kernelci/kernelci-core#3001
Implement a service to run a cron job in pipeline. This cron job will run
kci-dev maestro validate
command to run validation for builds and boots results of maestro against webdashboard.
The cron job is scheduled to run every Sunday at 12:00 AM.
The report will be uploaded to storage. An email notification will be sent out with report URL.