Skip to content

pipeline: Add android-mainline #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Conversation

helen-fornazier
Copy link

@helen-fornazier helen-fornazier commented Mar 25, 2024

Add definitions of android-mainline from legacy system to the new system.
Add android-mainline tree
Add lab-kontron and lab-pengutronix definitions
Add respective platforms

NOTE: please review this, I didn't test and I wrote based on what I saw from current code and legacy code, so I'm very unsure about this. Please let me know if there is any better way to check/test it.

Reference: #483

@pawiecz pawiecz self-requested a review March 25, 2024 18:01
@pawiecz pawiecz added the staging-skip Don't test automatically on staging.kernelci.org label Mar 25, 2024
Copy link
Contributor

@a-wai a-wai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR definitely demonstrates how documenting things becomes more and more urgent, as you're basically hitting the "only a few know" barrier, which is definitely on us (full-time contributors) to blame.

There are also stuff in there we never really discussed (like the mach parameter) so expect maybe a few contradictory opinions on that.

Finally, we have an (unwritten, again) rule of listing devices/runtimes/jobs/etc by alphabetical order (even if it's not fully enforced), can you please try to follow that principle in the future?

Copy link
Contributor

@pawiecz pawiecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's reduce the scope of this PR to include only: tree definition, build_configs adjustments and setting up kbuild_* jobs (moving baseline_* ones to a separate PR - together with labs and platforms definitions).

@helen-fornazier
Copy link
Author

@a-wai @pawiecz PR updated (except for the PR separation, please check my questions), please review it when you have some time (and thanks a lot for the review)

Copy link
Contributor

@a-wai a-wai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a small change left which I didn't spot before, otherwise should be good to go :)

After it's done feel free to drop the staging-skip label and undraft this PR

@helen-fornazier helen-fornazier changed the title [Draft] pipeline: Add android-mainline pipeline: Add android-mainline Apr 11, 2024
@helen-fornazier
Copy link
Author

helen-fornazier commented Apr 11, 2024

Only a small change left which I didn't spot before, otherwise should be good to go :)

After it's done feel free to drop the staging-skip label and undraft this PR

looks like I don't have permissions to drop labels

@helen-fornazier helen-fornazier marked this pull request as ready for review April 11, 2024 12:00
@nuclearcat nuclearcat removed the staging-skip Don't test automatically on staging.kernelci.org label Apr 11, 2024
Monitor linux `android` tree. Add build configs for `android-mainline`
branch.

Signed-off-by: Helen Koike <[email protected]>
@nuclearcat nuclearcat added the staging-skip Don't test automatically on staging.kernelci.org label Apr 11, 2024
Add kbuild jobs to compile the kernel for android-mainline branch

Signed-off-by: Helen Koike <[email protected]>
@nuclearcat nuclearcat removed the staging-skip Don't test automatically on staging.kernelci.org label Apr 11, 2024
Copy link
Contributor

@a-wai a-wai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@a-wai
Copy link
Contributor

a-wai commented Apr 11, 2024

Looks like I spoke too soon ;) Can you please add entries to the scheduler: section, so the builds are actually executed? (those should be quite straightforward)

@helen-fornazier
Copy link
Author

helen-fornazier commented Apr 11, 2024

Looks like I spoke too soon ;) Can you please add entries to the scheduler: section, so the builds are actually executed? (those should be quite straightforward)

should I just add the following? Or is there anything else?

  - job: kbuild-gcc-10-armel-android-mainline
    <<: *build-k8s-all
    
  - job: kbuild-gcc-10-armel-android-mainline-imx
    <<: *build-k8s-all

Do I need to add rules for selecting tree and branch?

@helen-fornazier
Copy link
Author

@a-wai I added a new commit to this PR adding entries to scheduler:, please check

Add entries to `scheduler:` section to run the builds for
android-mainline.

Signed-off-by: Helen Koike <[email protected]>
@nuclearcat nuclearcat added the staging-skip Don't test automatically on staging.kernelci.org label Apr 12, 2024
@nuclearcat
Copy link
Member

@a-wai
Copy link
Contributor

a-wai commented Apr 12, 2024

Indeed, I'm happily hitting that "Merge" button then :)

@a-wai a-wai added this pull request to the merge queue Apr 12, 2024
Merged via the queue into kernelci:main with commit 5a6204d Apr 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staging-skip Don't test automatically on staging.kernelci.org
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants