Repository navigation
Add canonical analysis_options.yaml and fix resulting lints - #57
Merged
Merged
Conversation
- Add root `analysis_options.yaml` (dart_flutter_team_lints + strict mode), governing all workspace members. - Add `dart_flutter_team_lints` to `tool/pubspec.yaml` dev_dependencies and sort dependencies. - Fix ~115 resulting findings: cascades, 80-col wraps, typed JSON / vm_service access, `unawaited`, `Future<void>.delayed`. - `packages/dash_discover/test/fixtures/analysis_options.yaml` disables four rules the fixtures deliberately violate; fixture sources untouched. - `package_facts.dart`: drop an unreachable `on ArgumentError` guard (`parseString(throwIfDiagnostics: false)` never throws it).
kevmoo
added a commit
that referenced
this pull request
Oct 3, 2026
- `path_package/negative/lib/idiomatic.dart` imports `package:path`; the fixture pubspec now says so (`path: ^1.9.0`). - Drop the `depend_on_referenced_packages` exemption from `test/fixtures/analysis_options.yaml` added in #57 to paper over this. - `PathPackageRule` never reads fixture pubspecs, so rule behavior is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
analysis_options.yaml(dart_flutter_team_lints + strict mode),governing all workspace members.
dart_flutter_team_lintstotool/pubspec.yamldev_dependencies andsort dependencies.
vm_service access,
unawaited,Future<void>.delayed.packages/dash_discover/test/fixtures/analysis_options.yamldisablesfour rules the fixtures deliberately violate; fixture sources untouched.
package_facts.dart: drop an unreachableon ArgumentErrorguard(
parseString(throwIfDiagnostics: false)never throws it).