File: Image previews like for CloudinaryImage #4198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
wmertens
reviewed
Apr 14, 2017
| target="__blank" | ||
| style={{ float: 'left', marginRight: '1em' }} | ||
| > | ||
| <img src={this.getImageSource()} style={{ height: 90 }} /> |
There was a problem hiding this comment.
it would be cleaner to do const src = this.getImageSource() and then use that in both places
| @@ -201,12 +223,19 @@ module.exports = Field.create({ | |||
| </div> | |||
| ); | |||
|
|
|||
| const imageContainer = ( | |||
| <div style={this.isImage() ? { marginBottom: '1em' } : null}> | |||
| {this.isImage() && this.renderImagePreview()} | |||
| @@ -65,6 +66,13 @@ module.exports = Field.create({ | |||
| hasFile () { | |||
| return this.hasExisting() || !!this.state.userSelectedFile; | |||
| }, | |||
| isImage() { | |||
| const href = this.props.value ? this.props.value.url : undefined; | |||
| return href && href.match(/\.(jpeg|jpg|gif|png)$/i) != null; | |||
There was a problem hiding this comment.
I think you can add a svg in there as well…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Added image preview in File field, like CloudinaryImage field
Related issues (if any)
Testing
eslint passed, data tests failed cause of timeouts etc.
Please maybe not approve pullrequest, but make such changes yourself in your dev env?
npm run test-allran successfully.