Fix entity-level reorg: match old event API for sidebar_tree.js#209
Merged
keyxmakerx merged 1 commit intomainfrom Mar 31, 2026
Merged
Fix entity-level reorg: match old event API for sidebar_tree.js#209keyxmakerx merged 1 commit intomainfrom
keyxmakerx merged 1 commit intomainfrom
Conversation
sidebar_tree.js expects: - data-reorg-active attribute on #sidebar-entity-tree element - camelCase event detail: hiddenEntityIds, hiddenNodeIds (not snake_case) - HTMX afterSwap wait for lazy-loaded tree before dispatching event - 50ms setTimeout after swap for tree initialization activateEntities() now: 1. Sets data-reorg-active on #sidebar-entity-tree 2. Sends camelCase hiddenEntityIds/hiddenNodeIds in event detail 3. If tree not loaded yet, waits for htmx:afterSwap then retries 4. Uses 50ms delay after swap for sidebar_tree.js init timing deactivateEntities() now removes data-reorg-active from tree element. This matches the exact behavior of the old sidebar_reorg.js that sidebar_tree.js was designed to work with. https://claude.ai/code/session_01A5jpDgqUvW6iLXXSj49F27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sidebar_tree.js expects:
activateEntities() now:
deactivateEntities() now removes data-reorg-active from tree element.
This matches the exact behavior of the old sidebar_reorg.js that sidebar_tree.js was designed to work with.
https://claude.ai/code/session_01A5jpDgqUvW6iLXXSj49F27