Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not CRUD on entries, files & conversations in DB for null user #958

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Do not CRUD on entries, files & conversations in DB for null user #958

merged 3 commits into from
Nov 11, 2024

Conversation

debanjum
Copy link
Member

@debanjum debanjum commented Nov 5, 2024 •
edited
Loading

Increase defense-in-depth by reducing paths to create, read, update or delete entries, files and conversations in DB when user is unset.

@debanjum debanjum force-pushed the no-crud-on-entries-files-chats-in-db-for-null-user branch from 8b0e6f2 to f4016a3 Compare November 5, 2024 08:28
@debanjum debanjum added the maintain Maintain code, documentation or project label Nov 5, 2024
Freddy-del

This comment was marked as spam.

Sign in to view

sabaimran
sabaimran reviewed Nov 9, 2024
View reviewed changes
Copy link
Member

@sabaimran sabaimran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a bit of clean-up suggestions, but this will be dope in assuring certain expected patterns.

src/khoj/database/adapters/__init__.py Outdated Show resolved Hide resolved
src/khoj/database/adapters/__init__.py Outdated Show resolved Hide resolved
src/khoj/database/adapters/__init__.py Outdated Show resolved Hide resolved
src/khoj/processor/content/github/github_to_entries.py Show resolved Hide resolved
src/khoj/search_type/text_search.py Show resolved Hide resolved
@debanjum debanjum force-pushed the no-crud-on-entries-files-chats-in-db-for-null-user branch from f4016a3 to caa6430 Compare November 11, 2024 02:49
@debanjum debanjum force-pushed the no-crud-on-entries-files-chats-in-db-for-null-user branch from caa6430 to 536fe99 Compare November 11, 2024 20:44
@debanjum debanjum merged commit ba2471d into master Nov 11, 2024
9 checks passed
@debanjum debanjum deleted the no-crud-on-entries-files-chats-in-db-for-null-user branch November 11, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Freddy-del Freddy-del Freddy-del left review comments

@sabaimran sabaimran sabaimran left review comments

Assignees
No one assigned
Labels
maintain Maintain code, documentation or project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@debanjum @sabaimran @Freddy-del