Support "canonical" handling of app and version labels #8122
Conversation
jshaughn
added
test: back-end/integration
There was a problem hiding this comment.
In all of the unit tests, you have now added this:
conf.IstioLabels.AppLabelName = "app"
conf.IstioLabels.VersionLabelName = "version"
Why don't you have some of these tests set those to empty string? That will exercise your new code. And since all of the tests don't have the canonical or kubernetes.io labels, the tests should all pass still.
Yes, this is a Draft PR, I'm not done coding but I wanted to start running CI. When all of the current tests are passing I'll write dedicated tests for the new use cases. I originally thought the same as you, that the tests will still pass. But its not true because the way the tests are written is that they access the serverConfig settings directly. I didn't want to convert all of it so instead I used the existing tests to prove that things still work if the user DOES set the fields explicitly in the config. The new default will be that the config is unset, and that is what the pending tests will verify. |
…nfig, and use labelNames other than "app" and "version". try to get the pod count right in the failing test
services, I think it screws up the caching.
No description provided.