docs: substantive tooltips on every INPUT_TYPES input#2016
Open
laurigates wants to merge 1 commit into
Open
Conversation
Adds substantive tooltips (>40 chars) to every input declaration across the
pack — 573 tooltips touched across 29 files.
What changed:
- 286 in-place tooltip-text expansions — replaced terse hints like
"Image to encode" / "end frame" / "mask" with semantic descriptions
including shape/range, pre-processing expectations, and special-case
behavior.
- 104 tooltip keys inserted into existing options dicts that previously
carried default/min/max but no tooltip.
- 183 bare `(TYPE,)` tuples extended to `(TYPE, {"tooltip": "..."})` —
mostly wired-socket inputs (CACHEARGS, MULTITALK_EMBEDS, SLGARGS,
EXPERIMENTALARGS, FETAARGS, …) that now name their producer node on
socket hover, so users can discover graph topology by hovering an
unconnected input.
Style:
- Wired-bundle sockets name the producer node ("connect from
WanVideoCacheArgs", etc.).
- Numeric inputs include units / sentinel-value semantics inline
(e.g. riflex_freq_index: "disabled when 0, default 6").
- BOOLEAN tooltips lead with the *true* behavior.
- COMBO tooltips describe the choice axis, not enumerate members.
Latent bugs caught and fixed along the way:
- WanVideoAnimateEmbeds.pose_images and .face_images both had tooltip
"end frame" — a copy-paste from WanVideoImageToVideoEncode. Replaced
with descriptions of the DWPose-driving video and 512x512 face-identity
crop respectively (traced to consumer code around lines 1257 and 1322).
- NormalizeAudioLoudness.lufs had options key "tool" instead of
"tooltip" — typo suppressed the existing description. Renamed.
Verification:
- All 29 files compile clean (python -m py_compile).
- Round-trip verified via /object_info HTTP API.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2fe2728 to
baecf63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds substantive tooltips to every input declaration in
INPUT_TYPESacross the pack — 573 tooltips touched across 29 files. Coverage went from ~27% substantive descriptions to 100%; every input now has a hover description > 40 chars.Coverage delta
What changed
"Image to encode"/"end frame"/"mask"with semantic descriptions including shape/range, pre-processing expectations, and special-case behavior.default/min/maxbut notooltip.(TYPE,)tuples extended to(TYPE, {"tooltip": "..."})— mostly wired-socket inputs (CACHEARGS,MULTITALK_EMBEDS,SLGARGS,EXPERIMENTALARGS,FETAARGS,LOOPARGS,UNI3C_EMBEDS,FANTASYTALKING_EMBEDS, …) that now name their producer node on socket hover, so users can discover graph topology by hovering an unconnected input.Style
"… — connect from WanVideoCacheArgs", etc.).riflex_freq_index: "disabled when 0, default 6").BOOLEANtooltips lead with the true behavior.COMBOtooltips describe the choice axis, not enumerate members (the UI already shows them).Latent bugs caught + fixed along the way
WanVideoAnimateEmbeds.pose_imagesand.face_imagesboth had tooltip"end frame"— a copy-paste fromWanVideoImageToVideoEncode. Replaced with descriptions of the DWPose-driving video and the 512×512 face-identity crop respectively, traced to consumer code around lines 1257 and 1322.NormalizeAudioLoudness.lufshad options key"tool"instead of"tooltip"(typo) — suppressed the existing description from rendering. Renamed.Implementation notes
predict_with_cfgzero-init early-exit tuple fix from fix: return 3-tuple from predict_with_cfg use_zero_init early-exit #2011 and theWanVideoSchedulerVALIDATE_INPUTSstep-range fix from fix(scheduler): reject step ranges that produce empty timestep slices #2012) deliberately did NOT ride along — they're tracked separately.Verification
python -m py_compile)./object_info/<NodeClass>HTTP API — tooltips round-trip to the frontend correctly.Test plan
IMPORT FAILED).WanVideo*node to confirm the new tooltip renders.cache_argsonWanVideoSamplerto confirm socket-hover tooltips work and name the producer.curl -s http://127.0.0.1:8188/object_info/WanVideoSampler | jq '.WanVideoSampler.input.required.cfg[1].tooltip'.🤖 Generated with Claude Code