Fix lack of vertical scroll for Dialogs #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StackPanel uses infinite Width/Height, no content can use scroll when inside StackPanel. This fix uses Grid instead with content as Fill. This resolves the problem and give us vertical scroll when required. StackPanel is very convenient to use but this problem make it almost a bug rather than a useful control. I tend to avoid it at all cost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StackPanel uses infinite Width/Height, no content can use scroll when inside StackPanel. This PR uses Grid instead with content as Fill. This resolves the problem and give us vertical scroll when required.
StackPanel is very convenient to use but this problem make it almost a bug rather than a useful control. I tend to avoid it at all cost.
Before VS after:
