Skip to content

Refactor dependencies display in nodes table for improved readability #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tungleduyxyz merged 2 commits into from
Nov 7, 2025
Merged

Refactor dependencies display in nodes table for improved readability #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2aa5de5
Refactor dependencies display in nodes table for improved readability
piyushkalasariya Nov 6, 2025
f584a5a
Fix placeholder component descriptions in button and sidebar templates
piyushkalasariya Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/views/kaui/components/button/_button.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<%#
This is a placeholder breadcrumb component for standalone gem usage.
This is a placeholder button component for standalone gem usage.

This placeholder prevents "missing template" errors when running
the gem independently during development or testing.
%>

<!-- Breadcrumb placeholder for standalone gem -->
<!-- Button placeholder for standalone gem -->
4 changes: 2 additions & 2 deletions app/views/kaui/layouts/kaui_setting_sidebar.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<%#
This is a placeholder breadcrumb component for standalone gem usage.
This is a placeholder sidebar component for standalone gem usage.

This placeholder prevents "missing template" errors when running
the gem independently during development or testing.
%>

<!-- Breadcrumb placeholder for standalone gem -->
<!-- Sidebar placeholder for standalone gem -->
10 changes: 4 additions & 6 deletions app/views/kpm/nodes_info/_nodes_table.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,10 @@
<% end %>
<div>
<b>Dependencies</b>
<p>
<div>API: <%= node_info.api_version %></div>
<div>Plugin API: <%= node_info.plugin_api_version %></div>
<div>Platform: <%= node_info.platform_version %></div>
<div>Commons: <%= node_info.common_version %></div>
</p>
<p>API: <%= node_info.api_version %></p>
<p>Plugin API: <%= node_info.plugin_api_version %></p>
<p>Platform: <%= node_info.platform_version %></p>
<p>Commons: <%= node_info.common_version %></p>
</div>
</div>
</div>
Expand Down
4 changes: 2 additions & 2 deletions app/views/kpm/nodes_info/index.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
const $link = $(this);
const $pluginContainer = $link.closest('.official-plugin');

$('.plugin-link').removeAttr('data-remote data-method href');
$('.plugin-link').removeAttr('data-remote').removeAttr('data-method').removeAttr('href');
$(this).children().addClass('fa-spin');

$(this).addClass('loading');
Expand All @@ -112,7 +112,7 @@
});

<% if @installing %>
$('.plugin-link').removeAttr('data-remote data-method href');
$('.plugin-link').removeAttr('data-remote').removeAttr('data-method').removeAttr('href');
$('#nodes-table-wrapper').css({ opacity: 0.5 });
$('#install-in-progress').show();
$('#install-in-progress').children().addClass('fa-spin');
Expand Down
Loading