New plugin config option for all plugins#37
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support in the KPM UI to view and upload per-tenant plugin configuration for (running) plugins, aligning with the goal of moving plugin configuration into KPM.
Changes:
- Adds a new POST route and controller action to upload tenant plugin configuration.
- Fetches existing
PLUGIN_CONFIG_tenant keys and passes them to the plugins UI. - Adds a “Config” action in the plugins list and renders a Bootstrap modal with an upload form, plus minimal styling.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| config/routes.rb | Adds the POST endpoint to upload plugin configuration. |
| app/controllers/kpm/nodes_info_controller.rb | Fetches existing tenant plugin config on index; implements the upload action. |
| app/views/kpm/nodes_info/index.html.erb | Passes tenant plugin config data into the plugins partial. |
| app/views/kpm/nodes_info/_official_plugins.html.erb | Adds “Config” link and renders config modals. |
| app/views/kpm/nodes_info/_form_plugin_config.erb | New modal + form for editing/uploading plugin config. |
| app/assets/stylesheets/kpm/nodes_info.css | Adds styling for the plugin config modal elements. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues: