Skip to content

Conversation

@dtoxvanilla1991
Copy link

@dtoxvanilla1991 dtoxvanilla1991 commented Oct 22, 2025

Explain your changes

  • Built framework-agnostic getCookieOptions with explicit typing, optional env injection, and warnings when runtime config is incomplete.
  • Added whitespace handling and diagnostic logs so malformed cookie domains or missing NODE_ENV don’t slip through silently.
  • Wrote targeted Vitest coverage for defaults, overrides, runtime fallbacks, warnings, and removeTrailingSlash edge cases; all tests pass.

Checklist

🛟 If you need help, consider asking for advice over in the Kinde community.

@dtoxvanilla1991 dtoxvanilla1991 self-assigned this Oct 22, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 22, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 96.82540% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
lib/utils/getCookieOptions.ts 96.77% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@dtoxvanilla1991 dtoxvanilla1991 changed the title feat: add getCookieOptions and removeTrailingSlash utility functions … feat: add getCookieOptions utility function Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant