WIP: Listing variations by content type #462
Conversation
| {item?.head_title && <div className="headline">{item.head_title}</div>} | ||
| <HeadingTag className="title"> | ||
| {item.title ? item.title : item.id} | ||
| </HeadingTag> |
There was a problem hiding this comment.
This keeps the same tag that was used before (h2 or h3) for backwards compatibility, but ideally we would not use those tags, since this isn't part of the page outline (table of contents).
| const { item, HeadingTag = 'h3' } = props; | ||
| return ( | ||
| <> | ||
| {item?.head_title && <div className="headline">{item.head_title}</div>} |
There was a problem hiding this comment.
I really wish we could switch this class to use kicker instead of headline, especially since headline is also used for the heading at the top of the listing block.
| ); | ||
| }; | ||
|
|
||
| export default NewsItemSummary; |
There was a problem hiding this comment.
There's quite a bit repeated between the default summary and the custom ones for News Item and Event -- when really we are only changing the kicker. Should we be adding a Kicker component instead?
On the other hand, doing it this way makes it possible to show something entirely different than the title + description if that makes more sense for some content type.
| config.getComponent({ | ||
| name: 'Summary', | ||
| dependencies: [item['@type']], | ||
| }).component || DefaultSummary; |
There was a problem hiding this comment.
Does using a component in the registry just make it harder to explain than updating an object in config.settings (i.e. like contentTypeViews)?
| year: 'numeric', | ||
| month: 'long', | ||
| day: 'numeric', | ||
| }); |
There was a problem hiding this comment.
We ought to update the FormattedDate component in volto to use this instead of momentjs, but that'll have to be in a major version...
Opening a draft PR so I can put notes on things I want to discuss...
What's included here:
To do: