Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: The UI showing incorrect colors in night mode. #3998

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Conversation

MohitMaliFtechiz
Copy link
Collaborator

@MohitMaliFtechiz MohitMaliFtechiz commented Sep 20, 2024

Fixes #3991

Light Mode Night Mode
1726828112615 1726828113126
1726828112840 1726828113004

Apart from these, all other views use the Android standard colors in our project.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.09%. Comparing base (701c9c1) to head (2b796b0).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3998      +/-   ##
============================================
- Coverage     58.22%   58.09%   -0.14%     
+ Complexity     1601     1598       -3     
============================================
  Files           314      314              
  Lines         13050    13050              
  Branches       1657     1657              
============================================
- Hits           7598     7581      -17     
- Misses         4344     4364      +20     
+ Partials       1108     1105       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42
Copy link
Collaborator

@MohitMaliDeveloper What is the status here? Have all the colors cleanuped so we have clear light/dark modes without custom colors?

@MohitMaliFtechiz
Copy link
Collaborator Author

@MohitMaliDeveloper What is the status here? Have all the colors cleanuped so we have clear light/dark modes without custom colors?

@kelson42 Yes.

I was waiting for your reply on #3736 (comment), I have put the screenshots of the UI of donation popup in the PR description, if it looks okay to you than this PR is ready for review.

@kelson42
Copy link
Collaborator

kelson42 commented Oct 1, 2024

@MohitMaliDeveloper What is the status here? Have all the colors cleanuped so we have clear light/dark modes without custom colors?

@kelson42 Yes.

I was waiting for your reply on #3736 (comment), I have put the screenshots of the UI of donation popup in the PR description, if it looks okay to you than this PR is ready for review.

Please don't use any custom colors at all. Rely on default themes. I will treat the donate box separatly.

@MohitMaliFtechiz
Copy link
Collaborator Author

Please don't use any custom colors at all. Rely on default themes.

@kelson42 We are not using any custom colors in this, we are using the default theme color in our project. In this PR I have removed the custom colors from the project.

I will treat the donate box separately.

Okay, I have created a separate PR for this #4012.

@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as ready for review October 1, 2024 09:58
…eason related to the OverflowMenuButton (the three-dot default Android button) width.
@kelson42 kelson42 merged commit 38400df into main Oct 1, 2024
21 of 22 checks passed
@kelson42 kelson42 deleted the Fixes#3991 branch October 1, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Online library can not be retrieved
3 participants