Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHNL-16941] Refactor / Cleanup Forms Module #222

Open
wants to merge 7 commits into
base: feature/IAM-post-3.0.3-rebase
Choose a base branch
from
Open

[CHNL-16941] Refactor / Cleanup Forms Module #222

wants to merge 7 commits into from

Conversation

dan-peluso
Copy link
Contributor

@dan-peluso dan-peluso commented Feb 18, 2025 •
edited by jira bot
Loading

Description

  • renaming messaging to forms
  • removing localhost references
  • renaming webview class and changing visibility

Check List

  • Are you changing anything with the public API?
  • Are your changes backwards compatible with previous SDK Versions?
  • Have you tested this change on real device?
  • Have you added unit test coverage for your changes?
  • Have you verified that your changes are compatible with all Android versions the SDK currently supports?

Changelog / Code Overview

Test Plan

Related Issues/Tickets

CHNL-1694

@dan-peluso dan-peluso requested a review from a team as a code owner February 18, 2025 21:56
evan-masseau
evan-masseau approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@evan-masseau evan-masseau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-masseau evan-masseau evan-masseau approved these changes

@ajaysubra ajaysubra ajaysubra approved these changes

Assignees

@evan-masseau evan-masseau

@ab1470 ab1470

@kennyklaviyo kennyklaviyo

@ajaysubra ajaysubra

@belleklaviyo belleklaviyo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dan-peluso @evan-masseau @ajaysubra @ab1470 @kennyklaviyo @belleklaviyo