Skip to content

Commit

Permalink
fix(dist): declaring sideEffects: false in package.json
Browse files Browse the repository at this point in the history
Fix declaring `sideEffects: false` in the package.json file with inadvertently breaks the likely most common usage of the package using `import 'yet-another-color-picker'` specifically for its side effect of registering the custom element.
  • Loading branch information
kleinfreund committed Dec 17, 2024
1 parent 0292dcb commit 512142a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"dist/ColorPicker.js",
"dist/ColorPicker.d.ts"
],
"sideEffects": false,
"sideEffects": true,
"scripts": {
"build:js": "tsup --minify terser",
"build:css": "npx clean-css-cli src/ColorPicker.css --output dist/ColorPicker.css",
Expand Down

0 comments on commit 512142a

Please sign in to comment.