-
Notifications
You must be signed in to change notification settings - Fork 3
Arbitrator devnet redeploy #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for curate-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughThe changes update the Changes
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
web/package.json (1)
49-51
: Version alignment LGTM
Frontend devDependency now matches the contracts workspace, preventing mismatched ABIs during codegen. Remember to runyarn install
(which re-creates the lockfile) before pushing the tag.templates/index.ts (1)
1-18
: Consider externalising all “devnet constants” into a single config module
The top-level comment already flags the tech debt; with every devnet redeploy we touch multiple literals here. MovingarbitratorAddress
,arbitrableChainID
, etc., to a.env
file or shared JSON would eliminate manual edits and reduce merge conflicts.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lock
is excluded by!**/yarn.lock
,!**/*.lock
📒 Files selected for processing (3)
contracts/package.json
(1 hunks)templates/index.ts
(1 hunks)web/package.json
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Redirect rules - curate-v2
- GitHub Check: Header rules - curate-v2
- GitHub Check: Pages changed - curate-v2
🔇 Additional comments (2)
contracts/package.json (1)
88-90
: Confirm compatibility of@kleros/kleros-v2-contracts@^0.10.0
bump
We’ve located imports of@kleros/kleros-v2-contracts
in your codebase—this upgrade is pre-1.0 so may include breaking changes:• contracts/wagmi.config.testnet.ts
• contracts/wagmi.config.mainnet.ts
• contracts/wagmi.config.devnet.ts
• contracts/src/CurateV2.sol
• contracts/deploy/00-curate-v2.tsPlease run:
hardhat compile && yarn test yarn typechainand verify that:
- TypeChain types still build without errors.
- Any constructor or ABI changes in v2 contracts are reflected in your deployment scripts and mocks.
Confirm before merging.templates/index.ts (1)
8-11
: New devnet arbitrator address acknowledged – verify it’s the one emitted by v0.10 deploys
Given the hard-coded nature of this file, please sanity-check that0x1Bd44c4a4511DbFa7DC1d5BC201635596E7200f9
is the arbitrator address in the freshly deployed devnet (chain ID 421614).
bumped @kleros/kleros-v2-contracts to pick up the latest devnet contracts
PR-Codex overview
This PR focuses on upgrading dependencies across various packages, particularly updating
@kleros/kleros-v2-contracts
from version0.9.3
to0.10.0
, along with several other updates and removals inyarn.lock
andpackage.json
files.Detailed summary
@kleros/kleros-v2-contracts
to^0.10.0
incontracts/package.json
andweb/package.json
.arbitratorAddress
intemplates/index.ts
.yarn.lock
, including:@arbitrum/nitro-contracts
to3.0.0
.@openzeppelin/contracts
to4.7.3
and4.9.6
.@chainlink/contracts
to1.4.0
.@noble/ciphers
and@noble/curves
with new versions.yarn.lock
.Summary by CodeRabbit
Chores
Refactor