Skip to content

Fix non-contant format string err in go 1.26 - #1777

Merged
knative-prow[bot] merged 1 commit into
knative-extensions:mainfrom
dsimansk:pr/fix-format-string
Sep 18, 2026
Merged

knative-prow[bot] merged 1 commit into
knative-extensions:mainfrom
dsimansk:pr/fix-format-string

Conversation

@dsimansk

Copy link
Copy Markdown
Contributor

Changes

  • Fix non-contant format string err in go 1.26
Fix non-contant format string err in go 1.26

Related to knative/pkg#3392

/cc @gauron99

@knative-prow
knative-prow Bot requested a review from gauron99 September 18, 2026 16:50
@knative-prow knative-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 18, 2026
@knative-prow

knative-prow Bot commented Sep 18, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2026
@codecov

codecov Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.98%. Comparing base (4786252) to head (e9ff197).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/reconciler/trigger/trigger.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1777   +/-   ##
=======================================
  Coverage   58.98%   58.98%           
=======================================
  Files          58       58           
  Lines        3567     3567           
=======================================
  Hits         2104     2104           
  Misses       1373     1373           
  Partials       90       90           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gauron99

Copy link
Copy Markdown
Contributor

/lgtm

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2026
@knative-prow
knative-prow Bot merged commit 99d36ff into knative-extensions:main Sep 18, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants