Skip to content

Add missing functions to satisfy next version of cache.Store interface - #9422

Merged
knative-prow[bot] merged 2 commits into
knative:mainfrom
dsimansk:pr/prep-kube-136
Oct 9, 2026
Merged

knative-prow[bot] merged 2 commits into
knative:mainfrom
dsimansk:pr/prep-kube-136

Conversation

@dsimansk

@dsimansk dsimansk commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Fixes #

Proposed Changes

  • Add missing functions to satisfy next version of cache.Store interface

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Add missing functions to satisfy next version of cache.Store interface

/cc @creydr @Cali0707 @matzew

Preps for K8s 1.36 bump per: knative/pkg#3387

@knative-prow
knative-prow Bot requested review from Cali0707, creydr and matzew October 9, 2026 11:46
@knative-prow knative-prow Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 9, 2026
@dsimansk

dsimansk commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor Author

Fixes knative/pkg upgrade path to k8s 1.36:

  FAIL	knative.dev/eventing/cmd/apiserver_receive_adapter [build failed]
  # knative.dev/eventing/pkg/adapter/apiserver
  ?   	knative.dev/eventing/cmd/appender	[no test files]
  Error: pkg/adapter/apiserver/delegate.go:42:21: cannot use (*resourceDelegate)(nil) (value of type *resourceDelegate) as "k8s.io/client-go/tools/cache".Store value in variable declaration: *resourceDelegate does not implement "k8s.io/client-go/tools/cache".Store (missing method Bookmark)
  Error: pkg/adapter/apiserver/filter.go:32:21: cannot use (*controllerFilter)(nil) (value of type *controllerFilter) as "k8s.io/client-go/tools/cache".Store value in variable declaration: *controllerFilter does not implement "k8s.io/client-go/tools/cache".Store (missing method Bookmark)
  Error: pkg/adapter/apiserver/adapter.go:200:29: cannot use &resourceDelegate{…} (value of type *resourceDelegate) as "k8s.io/client-go/tools/cache".Store value in variable declaration: *resourceDelegate does not implement "k8s.io/client-go/tools/cache".Store (missing method Bookmark)
  Error: pkg/adapter/apiserver/adapter.go:213:14: cannot use &controllerFilter{…} (value of type *controllerFilter) as "k8s.io/client-go/tools/cache".Store value in assignment: *controllerFilter does not implement "k8s.io/client-go/tools/cache".Store (missing method Bookmark)

@codecov

codecov Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.34%. Comparing base (4e4cf26) to head (a855f11).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9422      +/-   ##
==========================================
+ Coverage   51.26%   51.34%   +0.07%     
==========================================
  Files         411      411              
  Lines       22183    22187       +4     
==========================================
+ Hits        11372    11391      +19     
+ Misses       9931     9915      -16     
- Partials      880      881       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@creydr

creydr commented Oct 9, 2026

Copy link
Copy Markdown
Member

/retest

@creydr creydr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2026
@knative-prow

knative-prow Bot commented Oct 9, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow
knative-prow Bot merged commit 2cf3460 into knative:main Oct 9, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants