refactor(mcp): add newSuccessResult helper and update resources - #3189
Conversation
|
Hi @intojhanurag. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3189 +/- ##
=======================================
Coverage 51.81% 51.81%
=======================================
Files 162 162
Lines 19131 19133 +2
=======================================
+ Hits 9912 9914 +2
Misses 8241 8241
Partials 978 978
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey @gauron99 , These tests are failing due to my set of changes or It is internal issue ? |
|
/retest |
|
/retest another one which, if this rerun doesn't succeed, could be rebased on |
ecb1d92 to
5cc1278
Compare
|
Hey @gauron99 , This one is ready now. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, intojhanurag, lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add newSuccessResult helper and update resources