feat(cluster): install act for local GitHub Actions workflow runs - #3968
Merged
Conversation
knative-prow
Bot
added
kind/enhancement
knative-prow
Bot
added
the
size/L
lkingland
force-pushed
the
coder.functions.2/62
branch
3 times, most recently
from
July 28, 2026 00:14
c613f6e to
0a3dbbc
Compare
gauron99
reviewed
Jul 29, 2026
Adds act (nektos/act v0.2.88) via func cluster create into $XDG_CONFIG_HOME/func/bin, with tar.gz extract support (ArchiveEntry). Windows: close archive handles before renaming over the download path (os.Rename Access is denied while the source is still open). e2e config-ci prefers managed BinDir/act over bare PATH. Functions#62
Address review on knative#3968: PR claimed ActOverride/act but they were dropped as unused after lint. Restore ActOverride + exported Act() (BinDir then PATH), sample FUNC_TEST_ACT like kubectl/kind, and resolve act in e2e config-ci via ClusterConfig.Act() instead of hand-building config.Dir(). Functions#62
lkingland
force-pushed
the
coder.functions.2/62
branch
from
July 30, 2026 06:00
0a3dbbc to
f63dcbd
Compare
Member
Author
|
@gauron99 Good catch — they were dropped when golangci flagged an unused unexported Restored and wired properly in the latest commit:
Thanks! |
gauron99
reviewed
Jul 31, 2026
| Checksums: actChecksums, | ||
| ArchiveEntry: "act", | ||
| URL: func(goos, goarch string) string { | ||
| // GitHub release asset names are case-insensitive, so goos |
Contributor
There was a problem hiding this comment.
note: I verified the case-insensivity too but did not find any documentation on it; if GH ever changes that CDN behaviour, we might get some failures :D
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
func cluster createinto$XDG_CONFIG_HOME/func/bin, alongside kubectl and kind — sofunc config ciworkflows can be exercised locally..tar.gzinstall path inpkg/cluster/binaries.go(ArchiveEntry): verify the archive SHA-256, then extract a regular-file entry atomically (size/type guards). Windows: close archive handles before renaming over the download path.ActOverride+ exportedClusterConfig.Act()(managed BinDir, then PATH); CLI samplesFUNC_TEST_ACTlike kubectl/kind.cluster.ClusterConfig{…}.Act()(not a hand-builtconfig.Dir()path).extractFromTarGz; cache hit is existence-only (archive pin ≠ extracted binary).Checksums match the official v0.2.88
checksums.txtfor linux/darwin amd64+arm64./kind enhancement
Release Note
Docs
Functions#62