Skip to content

[release-1.19] [controller] fix depth metrics - #3254

Merged
knative-prow[bot] merged 2 commits into
knative:release-1.19from
knative-prow-robot:cherry-pick-3253-to-release-1.19
Sep 9, 2025
Merged

knative-prow[bot] merged 2 commits into
knative:release-1.19from
knative-prow-robot:cherry-pick-3253-to-release-1.19

Conversation

@knative-prow-robot

Copy link
Copy Markdown
Contributor

This is an automated cherry-pick of #3253

@knative-prow
knative-prow Bot requested review from creydr and skonto September 9, 2025 01:10
@knative-prow knative-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 9, 2025
@dprotaso

dprotaso commented Sep 9, 2025

Copy link
Copy Markdown
Member

/lgtm
/approve

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2025
@knative-prow

knative-prow Bot commented Sep 9, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2025
@knative-prow
knative-prow Bot merged commit 077dcf0 into knative:release-1.19 Sep 9, 2025
33 checks passed
@codecov

codecov Bot commented Sep 9, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.61%. Comparing base (9aa1144) to head (0c824e8).
⚠️ Report is 1 commits behind head on release-1.19.

Files with missing lines Patch % Lines
controller/queue_metrics.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.19    #3254      +/-   ##
================================================
- Coverage         74.64%   74.61%   -0.04%     
================================================
  Files               209      209              
  Lines             12025    12026       +1     
================================================
- Hits               8976     8973       -3     
- Misses             2770     2773       +3     
- Partials            279      280       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants