Skip to content

Fix h2-over-TLS client ALPN regression after network refactor - #3400

Merged
knative-prow[bot] merged 1 commit into
knative:mainfrom
dsimansk:pr/fix-h2-alpn
Oct 13, 2026
Merged

knative-prow[bot] merged 1 commit into
knative:mainfrom
dsimansk:pr/fix-h2-alpn

Conversation

@dsimansk

Copy link
Copy Markdown
Contributor

Changes

  • Fix h2-over-TLS client ALPN regression after network refactor

/cc @gauron99 @dprotaso @Cali0707

@knative-prow

knative-prow Bot commented Oct 13, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 13, 2026
@gauron99

Copy link
Copy Markdown

/lgtm

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2026
@codecov

codecov Bot commented Oct 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.26%. Comparing base (81e236f) to head (d52f860).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3400      +/-   ##
==========================================
+ Coverage   75.08%   75.26%   +0.17%     
==========================================
  Files         189      189              
  Lines        8353     8360       +7     
==========================================
+ Hits         6272     6292      +20     
+ Misses       1837     1824      -13     
  Partials      244      244              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knative-prow
knative-prow Bot merged commit 0795cb8 into knative:main Oct 13, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants