-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix repeat option #15813
fix repeat option #15813
Conversation
Signed-off-by: alingse <[email protected]>
Welcome @alingse! It looks like this is your first PR to knative/serving 🎉 |
Hi @alingse. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Thanks for the fix, @alingse! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15813 +/- ##
==========================================
- Coverage 75.05% 75.05% -0.01%
==========================================
Files 222 222
Lines 18075 18074 -1
==========================================
- Hits 13566 13565 -1
Misses 4158 4158
Partials 351 351 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alingse, dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override "codecov/project" coverage report is wrong which is weird |
@dprotaso: Overrode contexts on behalf of dprotaso: codecov/project In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fixes #
Proposed Changes
asFlag(FeaturePodSpecHostIPC, &nc.PodSpecHostIPC),
Release Note