Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix repeat option #15813

Merged
merged 1 commit into from
Mar 21, 2025
Merged

fix repeat option #15813

merged 1 commit into from
Mar 21, 2025

Conversation

alingse
Copy link
Contributor

@alingse alingse commented Mar 19, 2025

Fixes #

Proposed Changes

  • fix repeat asFlag(FeaturePodSpecHostIPC, &nc.PodSpecHostIPC),

Release Note


Signed-off-by: alingse <[email protected]>
@knative-prow knative-prow bot requested review from dprotaso and dsimansk March 19, 2025 15:39
@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 19, 2025
Copy link

knative-prow bot commented Mar 19, 2025

Welcome @alingse! It looks like this is your first PR to knative/serving 🎉

Copy link

knative-prow bot commented Mar 19, 2025

Hi @alingse. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 19, 2025
@dsimansk
Copy link
Contributor

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 19, 2025
@dsimansk
Copy link
Contributor

Thanks for the fix, @alingse!

Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.05%. Comparing base (c09ff6c) to head (3937ec2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15813      +/-   ##
==========================================
- Coverage   75.05%   75.05%   -0.01%     
==========================================
  Files         222      222              
  Lines       18075    18074       -1     
==========================================
- Hits        13566    13565       -1     
  Misses       4158     4158              
  Partials      351      351              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2025
Copy link

knative-prow bot commented Mar 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alingse, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2025
@dprotaso
Copy link
Member

/override "codecov/project"

coverage report is wrong which is weird

Copy link

knative-prow bot commented Mar 21, 2025

@dprotaso: Overrode contexts on behalf of dprotaso: codecov/project

In response to this:

/override "codecov/project"

coverage report is wrong which is weird

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot merged commit a3be1ef into knative:main Mar 21, 2025
68 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants