Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for CSI volumes #15815

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mwritescode
Copy link

Fixes #11069

Description

This feature introduces support for Container Storage Interface (CSI) volumes in Knative Serving, enabling users to integrate with a wide variety of storage solutions through the Kubernetes CSI standard. This enhancement allows Knative services to leverage enterprise storage systems, cloud provider volumes, and other storage implementations that support the CSI specification, while maintaining Knative's serverless principles.

Proposed Changes

  • Add support for CSI volume type in Knative Serving
  • Enable users to mount CSI volumes into their Knative service containers
  • Update relevant documentation and examples to include usage of CSI volumes
  • Add feature flag control for CSI volume support

Release Note

Adding support for CSI (Container Storage Interface) volumes. This feature allows users to mount CSI-compatible storage volumes into their Knative service containers. It enables integration with enterprise storage solutions and cloud provider storage services that implement the CSI specification. The feature is behind the flag `kubernetes.podspec-volumes-csi`.

Copy link

linux-foundation-easycla bot commented Mar 21, 2025

CLA Signed


The committers listed above are authorized under a signed CLA.

Copy link

knative-prow bot commented Mar 21, 2025

Welcome @mwritescode! It looks like this is your first PR to knative/serving 🎉

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 21, 2025
Copy link

knative-prow bot commented Mar 21, 2025

Hi @mwritescode. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

knative-prow bot commented Mar 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mwritescode
Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from dsimansk and skonto March 21, 2025 17:49
@dsimansk
Copy link
Contributor

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 26, 2025
Copy link

knative-prow bot commented Mar 26, 2025

@mwritescode: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-tests_serving_main 3380251 link true /test unit-tests
build-tests_serving_main 3380251 link true /test build-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Message: `CSI volume support is disabled, but found CSI volume foo`,
}).Also(
&apis.FieldError{Message: "must not set the field(s)", Paths: []string{"csi"}
})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwritescode could you pls take a look literals syntax in tests?

@dsimansk
Copy link
Contributor

@dprotaso @skonto what's your opinion on adding the support? Personally, I'd like to see a bit of e2e test coverage to confirm and ensure it's supportable from our point of view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility with Secret Store CSI Driver?
2 participants