-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[wip] update deps to drop h2c lib #16280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16280 +/- ##
==========================================
- Coverage 80.04% 80.03% -0.01%
==========================================
Files 215 215
Lines 13320 13320
==========================================
- Hits 10662 10661 -1
- Misses 2296 2298 +2
+ Partials 362 361 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@linkvt do you know anyone that could help debug why the kourier-tls settings are failing? |
|
Hi @dprotaso , My test setup was:
I would assume that the current implementation will not work with these 6 test cases. One example was that when I used kourier with TLS and HTTP2 enabled my naive implementation would always try to use HTTP2 internally despite me using curl --http1.1 -> ingress -> knative -> http1 only service. I learned in the meanwhile that e.g. envoy is able to translate between http1, http2 and http3 requests and that this may be more desired in our case as well, so that the client request protocol does not determine which protocol is used internally. I guess this would be a larger change though. Feel free to ping me in slack, we can look at this together but I think you will see the issue already when using my test setup described above. |
Testing - knative/pkg#3298