Refactor all occurences of non-contant format string err

[dsimansk]

Fixes #

Proposed Changes

• Refactor all occurences of non-contant format string err

Release Note

Refactor all occurences of non-contant format string err

Prep for go 1.26 to avoid error like:
knative/pkg#3392

/cc @dprotaso @gauron99

[gauron99]

/lgtm

[codecov]

Codecov Report

❌ Patch coverage is 92.10526% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.32%. Comparing base (618b0c2) to head (c51c1b9).
⚠️ Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
...kg/apis/serving/v1beta1/domainmapping_lifecycle.go	75.00%	2 Missing ⚠️
pkg/apis/serving/v1/route_lifecycle.go	88.88%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16690      +/-   ##
==========================================
+ Coverage   80.29%   80.32%   +0.02%     
==========================================
  Files         217      217              
  Lines       13560    13560              
==========================================
+ Hits        10888    10892       +4     
+ Misses       2309     2304       -5     
- Partials      363      364       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[dsimansk]

@gauron99 I'll try to move the needle on other repos due to pkg/apis owner restrictions.

[dsimansk]

/test istio-latest-no-mesh

[dsimansk]

@evankanderson PTAL if you happen to go by, thanks a lot!

The PR's fixing non-constant format string error that would start to appear once knative/pkg moves to go 1.26+. This is the last change from downstream tests to get knative/pkg tests green.

knative/pkg#3392

Afterwards k8s 1.36 update should be smoother without formatting error noise.
knative/pkg#3387

[dsimansk]

/cc @knative/steering-committee the above comment ^^

[Copilot]

Copilot review overview

🟢 Approval recommended

No unresolved review comments remain, and all reviewers assessed the changes as approval-ready.

Review effort: Lite
Findings: None

What changed in this PR

Refactors lifecycle condition messages to use constant format strings for Go 1.26 compatibility.

Changes:

• Uses %s placeholders for dynamic messages.
• Removes unnecessary fmt usage.
• Preserves condition-message propagation.

File	Description
pkg/​apis/​serving/​v1beta1/​domainmapping_lifecycle.go	Updates DomainMapping condition formatting
pkg/​apis/​serving/​v1/​service_lifecycle.go	Updates Service condition formatting
pkg/​apis/​serving/​v1/​route_lifecycle.go	Updates Route condition formatting
pkg/​apis/​serving/​v1/​revision_lifecycle.go	Updates Revision condition formatting
pkg/​apis/​serving/​k8s_lifecycle.go	Updates Deployment condition propagation
pkg/​apis/​autoscaling/​v1alpha1/​pa_lifecycle.go	Updates PodAutoscaler condition formatting
pkg/​apis/​autoscaling/​v1alpha1/​metric_lifecycle.go	Updates Metric condition formatting

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[aliok]

/lgtm
/approve

[aliok]

/assign @dprotaso

[aliok]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/apis/OWNERS [aliok]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aliok]

/override istio-latest-no-mesh-tls_serving_main

[knative-prow]

@aliok: Overrode contexts on behalf of aliok: istio-latest-no-mesh-tls_serving_main

Details

In response to this:

/override istio-latest-no-mesh-tls_serving_main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.