Optimize haveIntersection function for better performance#40
Open
jeremyssocial wants to merge 1 commit intoknub:masterfrom
Open
Optimize haveIntersection function for better performance#40jeremyssocial wants to merge 1 commit intoknub:masterfrom
jeremyssocial wants to merge 1 commit intoknub:masterfrom
Conversation
…rrays using Set and Array.prototype.some() for O(n) time complexity
Author
|
(also refactored the code) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request aims to optimize the haveIntersection function for better performance. The previous implementation used nested for loops, which had a time complexity of O(n^2). The new implementation uses a Set and Array.prototype.some() method, which has a time complexity of O(n) and improves the overall performance of the function. This change will ensure that the function runs more efficiently and will improve the user experience for those who utilize this function.