Open
Conversation
- Remove mixingradle dependency -> it's included in neoforge by 1.21.1 - Fix build.gradle variable assignment syntax to new standard
- MixinControllerValidator: Use WrapOperation instead of redirect to allow for potential chained Wraps from other mods. - MixinSettingToggleButton: Removed an unneccessary redirect of a function call even though it only wanted to inject three other function calls after it.
It does exactly the same thing appflux already does: https://github.com/GlodBlock/ExtendedAE/blob/appflux/1.21.1-neoforge/src/main/java/com/glodblock/github/appflux/mixins/MixinPatternProviderLogicHost.java
Disable MixinCraftingCPUCluster when ExtendedAE Plus is active since it does the same thing in a somewhat more elegant manner and since both redirect, they would conflict otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another attempt at optimizing some mixins.
These are only the changes that would have worked from the last PR anyways.
As I mentioned in a comment on the (closed) last PR, there is still one overwrite in place. It doesn't cause an issue (as far as I could tell with the mods I tested with), so I didn't spend too much time investigating how to get rid of that as well.
I kinda also want to return to mixing into the TargetCache instead of fully replacing it, but I'm not sure how to do that currently, as the decision logic for the blocking feature got moved there and needs the ConfigManager which you added in your own copy of it. I have an idea on how to handle that by basically writing that with a setter instead, but it's not completely perfect, so if I ever get around to working on that, I'll do it in a separate PR. I think that this change would also indirectly get rid of the overwrite, so that'd be neat.
Feedback welcome!