Fix broken crafting screens and Pattern Provider in forge/1.20.1#63
Closed
liquidcatmofu wants to merge 3 commits intoko-lja:forge/1.20.1from
Closed
Fix broken crafting screens and Pattern Provider in forge/1.20.1#63liquidcatmofu wants to merge 3 commits intoko-lja:forge/1.20.1from
liquidcatmofu wants to merge 3 commits intoko-lja:forge/1.20.1from
Conversation
fix typo fix gui clean fix position fix position
Owner
|
Sorry for the late reply, since it seems that these features are kinda brittle, and either work or don't, with no actual reason for it, i have been making all the widgets guarded, ie if they don't exist the screen will just open without and it'll show a warning at the top of the screen telling you that you're missing some, included with this will be a resource pack which contains all of the widgets, in case it did not work normally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed crafting screens and Pattern Provider functionality that were broken in the latest commits on the forge/1.20.1 branch.
Background
The issue affects both the published CurseForge version 1.3.3 and the latest development version, preventing users from accessing critical crafting features.
#45 #46 #60
Changes Made
@At("TAIL")to@At("RETURN")for proper initializationFixed Mixins
MixinPatternProviderMenuMixinPatternProviderScreenMixinProcessingEncodingPanelTesting
All core functionalities have been tested and verified:
✅ Crafting functionality (Next button, CPU, Crafting Status)
✅ Pattern Provider functionality (including Blocking Mode)
✅ Terminal functionality (including multiplier buttons)
Known Limitations
Crafting CPU Custom UI: The custom UI for the Crafting CPU screen has been disabled in this fix. During investigation, even the standard AE2 screen definition failed to load when applied through the custom style system. This appears to be a deeper compatibility issue that requires further investigation. The CPU screen now uses the standard AE2 layout, and all functionality remains intact.
Technical Details
The issue was caused by incorrect Mixin injection points. Using
@At("TAIL")injected code before parent class initialization completed, while@At("RETURN")ensures the entire constructor finishes before our code runs. This is critical for GUI components that depend on parent class setup.