Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: meta attributes for redesigned gallery item #4682

Merged
merged 4 commits into from
Jan 13, 2023

Conversation

preschian
Copy link
Member

@preschian preschian commented Jan 13, 2023

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

  • add meta attributes for redesigned gallery item

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@netlify
Copy link

netlify bot commented Jan 13, 2023

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 6d6a232
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63c18b0f97e15700081cea67
😎 Deploy Preview https://deploy-preview-4682--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@preschian preschian marked this pull request as ready for review January 13, 2023 08:08
@preschian preschian requested a review from a team as a code owner January 13, 2023 08:08
@preschian preschian requested review from Jarsen136 and prachi00 and removed request for a team January 13, 2023 08:08
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How could we test the seo content for gallery item? A screenshot would be better.

@preschian preschian changed the title feat: meta attributes for gallery item feat: meta attributes for redesigned gallery item Jan 13, 2023
@roiLeo
Copy link
Contributor

roiLeo commented Jan 13, 2023

How could we test the seo content for gallery item? A screenshot would be better.

Meta SEO inspector

Related doc for Nuxt3 meta, have you tried to use composable useHead?

@preschian
Copy link
Member Author

have you tried to use composable useHead?

still fails on my local when I tried with that composable

Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Jan 13, 2023
@yangwao
Copy link
Member

yangwao commented Jan 13, 2023

pay 50 usd
merge when good to go

@yangwao
Copy link
Member

yangwao commented Jan 13, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 27.96 USD/KSM ~ 1.788 $KSM
🧗 DY4SQF2iD456tH89aQtz5wv1EV3BbSW8wKKuMcwbmXaj1pM
🔗 0xb76f7e66708bbfdbfea9d88aa7e5586be2fd622a47282fb9c9c6b8706fed88db

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jan 13, 2023
@Jarsen136
Copy link
Contributor

Hey @preschian , could you also check why the cf page building fail? Otherwise lgtm
image

@preschian
Copy link
Member Author

Hey @preschian , could you also check why the cf page building fail?

this one because of my PR yesterday. let me sync with main first, should be fixed in this PR #4680

@codeclimate
Copy link

codeclimate bot commented Jan 13, 2023

Code Climate has analyzed commit 9066408 and detected 0 issues on this pull request.

View more on Code Climate.

@Jarsen136
Copy link
Contributor

Hey @preschian , could you also check why the cf page building fail?

this one because of my PR yesterday. let me sync with main first, should be fixed in this PR #4680

Yes, it works.

@Jarsen136
Copy link
Contributor

Need one more approval to merge this PR. @roiLeo

@roiLeo roiLeo enabled auto-merge January 13, 2023 16:32
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@yangwao yangwao disabled auto-merge January 13, 2023 16:47
@yangwao yangwao enabled auto-merge January 13, 2023 16:47
@yangwao yangwao merged commit 4bf3c12 into main Jan 13, 2023
@yangwao yangwao deleted the feat/meta-head-gallery-item branch January 13, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants