switch from local removeFirst copy to iteration for pairing #452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we don't need a mutable copy of `array` to alter it, instead we can just drop the first element
we don't need to alter a mutable copy of `array`, instead we can just drop the first element.
We don't need to alter a local copy of `array` to generate each pair, instead use stride(from:to:by). In my simple [tests](https://gist.github.com/TheIronBorn/cc0507b36fddad291aa34674eb52ad8f), this can be up to an order of magnitude faster.
kelvinlauKL
reviewed
Jun 4, 2017
Select Minimum Maximum/Maximum.swift
Outdated
|
|
||
| func maximum<T: Comparable>(_ array: [T]) -> T? { | ||
| var array = array | ||
| guard !array.isEmpty else { |
There was a problem hiding this comment.
Since we're force unwrapping array.first due to this guard statement's guarantee, let's merge the two:
// guards against the empty array and also extracts the first element of the array
guard let maximum = array.first else { return nil }
|
Oh yeah that's fine. I'll implement in a minute. |
|
Looks great! Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description