Skip to content

Swiftlint fixes #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 4, 2017
Merged

Swiftlint fixes #456

merged 8 commits into from
May 4, 2017

Conversation

jawwad
Copy link
Contributor

@jawwad jawwad commented May 3, 2017

Checklist

Description

This PR contains various swiftlint fixes

jawwad added 8 commits May 4, 2017 04:01
warning: Unused Closure Parameter Violation: Unused parameters in a closure should be replaced with _.
warning: Redundant Discardable Let Violation: Prefer `_ = foo()` over `let _ = foo()` when discarding a result from a function.
warning: Operator Function Whitespace Violation: Operators should be surrounded by a single whitespace when defining them.

Apple has also used spacing in The Swift Programming Language book
https://developer.apple.com/library/content/documentation/Swift/Conceptual/Swift_Programming_Language/AdvancedOperators.html#//apple_ref/doc/uid/TP40014097-CH27-ID42
warning: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals.
Rule: implicit_getter
warning: Implicit Getter Violation: Computed read-only properties should avoid using the get keyword.
warning: Unused Optional Binding Violation: Prefer `!= nil` over `let _ =` ()
@kelvinlauKL kelvinlauKL merged commit b2f50be into kodecocodes:master May 4, 2017
@kelvinlauKL
Copy link
Member

cheers!

@jawwad jawwad deleted the swiftlint-fixes branch February 24, 2019 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants