Repository navigation
fix(kgui): Keep a write card's face through reports that name nobody - #69
Merged
Merged
Conversation
An app's report that named no project dropped the face of the card it arrived on. A card can carry two transfers: the fetch of an app's data folder and the install it announced (kodediy/kode-sdk#123), or an install that starts again once its copies are on the card. The later one names nobody until its image is read, so the face went for the time a download takes to open and came back at the first chunk. The card now keeps its face through such a stretch and asks its folder again, once: the transfer before may be the one that wrote it, and the folder was last asked when the card rose. That is also what puts a freshly fetched icon on the card from the install's first report.
kodeOS build
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
The write card dropped its face, the app's icon and name, whenever a progress report named no project, and took it again at the first chunk. An install from a URL names no project until its image is read, so through the opening of the download the card wore the letters of the URL's file name. kgui also asked the app's data folder once, when the card rose, which is before a fetch has written it.
Test Scenarios
kgui_wface: 13 cases, 5 new),check_layers.sh,idf.py buildon v6.1 with no warnings, size, RAM and the MISRA gate (nothing past the baseline),tools/tool_tests.sh18 of 18, andtools/host_tests.sh5548 cases with the SDK branch of feat(kaos): Keep a fetch's card up for the install it announces kode-sdk#123.appdata_get ... install=onthe card stays at 0 % wearing the app's letters;tools/kmirror.py: the states were taken as screenshots.Related links