Skip to content

fix(kgui): Keep a write card's face through reports that name nobody - #69

Merged
jbenedictocenteno merged 1 commit into
developfrom
fix/kgui-write-face-kept
Nov 13, 2026
Merged

jbenedictocenteno merged 1 commit into
developfrom
fix/kgui-write-face-kept

Conversation

@jbenedictocenteno

Copy link
Copy Markdown
Contributor

Description of Change

The write card dropped its face, the app's icon and name, whenever a progress report named no project, and took it again at the first chunk. An install from a URL names no project until its image is read, so through the opening of the download the card wore the letters of the URL's file name. kgui also asked the app's data folder once, when the card rose, which is before a fetch has written it.

  • A report that names no project keeps the card's face and asks the data folder again, once per nameless stretch; the answer is drawn when it has all arrived. A report of kodeOS or the radio still drops the face, and another project still takes its own.
  • With feat(kaos): Keep a fetch's card up for the install it announces kode-sdk#123, where a fetch that announces its install keeps its card up, the card goes from the fetch to the install wearing the icon and the name the fetch just wrote.

Test Scenarios

  • kgui's host cases (kgui_wface: 13 cases, 5 new), check_layers.sh, idf.py build on v6.1 with no warnings, size, RAM and the MISRA gate (nothing past the baseline), tools/tool_tests.sh 18 of 18, and tools/host_tests.sh 5548 cases with the SDK branch of feat(kaos): Keep a fetch's card up for the install it announces kode-sdk#123.
  • On a DVT board with that SDK branch, with screenshots:
    • after appdata_get ... install=on the card stays at 0 % wearing the app's letters;
    • when the install is asked for, the disc becomes the fetched icon before the figure moves, the install completes and the app is in Apps;
    • a fetch whose install never comes ends its card by itself, and one whose install is refused ends it at once.
  • No look through tools/kmirror.py: the states were taken as screenshots.

Related links

An app's report that named no project dropped the face of the card it
arrived on. A card can carry two transfers: the fetch of an app's data
folder and the install it announced (kodediy/kode-sdk#123), or an
install that starts again once its copies are on the card. The later
one names nobody until its image is read, so the face went for the time
a download takes to open and came back at the first chunk.

The card now keeps its face through such a stretch and asks its folder
again, once: the transfer before may be the one that wrote it, and the
folder was last asked when the card rose. That is also what puts a
freshly fetched icon on the card from the install's first report.
@github-actions

Copy link
Copy Markdown

kodeOS build

Check Result
Image size kodeos.bin 3870960 of 4194304 bytes, 323344 left (7%)
Internal RAM kodeos.elf 35 statics of 2048 bytes or more in internal RAM, all listed
Starts starts: 23 Active Objects and 6 door set-ups, each beside what it starts
MISRA MISRA: 1834 findings in 187 files, none past the baseline
::warning::kodeos.bin is within 10% of its ceiling (323344 bytes, 7% left of 4194304)

@jbenedictocenteno
jbenedictocenteno merged commit 9bcfdb7 into develop Nov 13, 2026
6 checks passed
@jbenedictocenteno
jbenedictocenteno deleted the fix/kgui-write-face-kept branch November 13, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant