Repository navigation
fix(kdrv): Mount the microSD on four lines and prove it takes a write - #110
Merged
Merged
Conversation
Counterfeit cards read on four lines and fail the first write there, so everyday mounts used one line. A mount that comes up on four lines now reads the card's last sector and writes the same bytes back. A card that fails this is unmounted, has its supply cycled and is mounted on one line. Closes #86
The write check ran on every mount: a failed write and a supply cycle each time for a card that refuses four lines, a rewrite of the last sector for one that takes them. The driver now remembers the last card it judged, in RAM for the boot, and mounts it as it was judged. The production row mounts its four lines with the new check_req knob off, so it judges the slot and not the card, and the mount that follows it is the checked one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Counterfeit cards read on four data lines and fail the first write there, so everyday mounts used one line for every card.
check_req): it judges the slot, not the card. The mount that follows it is the checked one.Test Scenarios
tools/host_tests.shandtools/check_layers.sh, green at this branch.Related links
Closes #86