Repository navigation
test(kaos): Keep the count of the read in a card folder's case - #116
Merged
Merged
Conversation
glibc marks fread() warn_unused_result, and a cast to void does not silence that under GCC. CI builds the host suites with -Werror, so the main suite did not build on develop. The case keeps the count and checks it against the file it expects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
The main host suite does not build on
developin CI. A case added with #114 reads a file back with(void)fread(...). glibc marksfread()warn_unused_result, a cast to void does not silence that under GCC, and CI builds the suites with-Werror:clang on macOS accepts it, which is how it passed every local run. The case now keeps the count and checks it against the file it expects.
It is the only such call added since the last green run: the test code added since then was searched for the other calls glibc marks the same way.
Test Scenarios
tests/hostbuilt and run at this branch: 5338 cases, none failing.develop's head lists nothing else of ours as an error. It cannot show this one, since macOS's libc does not markfread(): this pull request's own CI run is the check.Related links