Open
Conversation
- Add CDFTrackingDataSerializer with placeholder implementation - Add failing test using common-data-format-validator - Add Provider.CDF enum value - Add common-data-format-validator to test requirements
Use bugfix/packaging branch which fixes schema file inclusion
Feat/cdf serializer
Also fixed the test path to the validators
koenvo
reviewed
Sep 23, 2025
| metadata_json["match"] = { | ||
| "match": { | ||
| "id": dataset.metadata.game_id, # same as for the jsonl | ||
| "kickoff_time": dataset.metadata.periods[0].start_time, |
Owner
There was a problem hiding this comment.
"kickoff_time": self.convert_time(dataset.metadata.periods[0].start_time)
koenvo
reviewed
Sep 23, 2025
|
|
||
| outputs.meta_data.write( | ||
| ( | ||
| json.dumps(metadata_json, default=self.default_serializer) |
Owner
There was a problem hiding this comment.
Would be better to make the serializer expliciet and don't use default_serializer.
[DOMAIN] Add PositionType.root
… any convertion with to_df()
get the position_group
…ion retrieving and get block on handling the class into kloppy.domain...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.