[fix] AttributeError: 'HTTPResponse' object has no attribute 'url'

[warren-bank]

Though not directly relevant.. this is also an issue with cpython, and there is an open pull request.

Pyodide uses Javascript XHR to perform the network request, and constructs an 'HTTPResponse' object from the XHR response. When doing so, a 'url' attribute should be added.

[warren-bank]

note to @koenvo

• it would really be appreciated if you could please push a minor release, so this can be added to Pyodide

note to self/others:

• until this is included in Pyodide, the following is a monkey patch to workaround the issue:

  import pyodide_http
  
  original_urlopen = pyodide_http._urllib.urlopen
  
  def modified_urlopen(url, *args, **kwargs):
      response = original_urlopen(url, *args, **kwargs)
      if isinstance(url, pyodide_http._urllib.urllib.request.Request):
          response.url = url.full_url
      else:
          response.url = url
      return response
  
  pyodide_http._urllib.urlopen = modified_urlopen

[koenvo]

Thanks for the PR Warren. The release script is kind of outdated. Let me solve that and push out a minor release.

[koenvo]

@warren-bank just released a new patch version: 0.2.2