Skip to content

Make BUILD_SHARED_LIBS a cache variable #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tpadioleau wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Make BUILD_SHARED_LIBS a cache variable #310

tpadioleau wants to merge 1 commit into from

Conversation

@tpadioleau
Copy link
Member

@tpadioleau tpadioleau commented Oct 15, 2025

Follow up of the PR #308, this PR makes BUILD_SHARED_LIBS a cache variable where the default value depends on the platform.

dalg24
dalg24 approved these changes Oct 15, 2025
View reviewed changes
Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer _INIT -> _DEFAULT

@tpadioleau
Copy link
Member Author

tpadioleau commented Oct 15, 2025

I would prefer _INIT -> _DEFAULT

Sure I will change. It was inspired from the variables CMAKE_<LANG>_FLAGS_INIT.

@dalg24
Copy link
Member

dalg24 commented Oct 15, 2025

I would prefer _INIT -> _DEFAULT

Sure I will change. It was inspired from the variables CMAKE_<LANG>_FLAGS_INIT.

Then let's stick with what you proposed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalg24 dalg24 dalg24 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tpadioleau @dalg24