Fix critical SSRF vulnerability in attachment upload - #3
Open
FaizanKolega wants to merge 1 commit into
Open
Conversation
Implement strict URL validation, block private IPs and metadata endpoints, disable dangerous protocols, validate redirects, and use URL parsing in the downloadAndStoreAttachment function to prevent Server-Side Request Forgery attacks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Disclosure Notice
This PR addresses a security vulnerability identified by Kolega.dev as part of our automated security remediation platform validation.
Disclosure Timeline:
We attempted to coordinate privately through NocoDB's official security reporting channel. After exceeding the published response SLA without acknowledgment, we are proceeding with public disclosure to ensure the community can protect their deployments.
Vulnerability identified and fix provided by Kolega.dev (https://kolega.dev/)
Implement strict URL validation, block private IPs and metadata endpoints, disable dangerous protocols, validate redirects, and use URL parsing in the downloadAndStoreAttachment function to prevent Server-Side Request Forgery attacks.
Change Summary
Provide summary of changes with issue number if any.
Change type
Test/ Verification
Provide summary of changes.
Additional information / screenshots (optional)
Anything for maintainers to be made aware of
Security Disclosure Notice
This PR addresses a security vulnerability identified by Kolega.dev as part of our automated security remediation platform validation.
Disclosure Timeline:
We attempted to coordinate privately through NocoDB's official security reporting channel. After exceeding the published response SLA without acknowledgment, we are proceeding with public disclosure to ensure the community can protect their deployments.
Vulnerability identified and fix provided by Kolega.dev